Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bud --layers doesn't show ImageID in last line #1237

Closed
TomSweeneyRedHat opened this issue Dec 14, 2018 · 2 comments
Closed

bud --layers doesn't show ImageID in last line #1237

TomSweeneyRedHat opened this issue Dec 14, 2018 · 2 comments

Comments

@TomSweeneyRedHat
Copy link
Member

Description
When using the --layers flag, the ImageID is shown in the next to last line and then the COMMIT confirmation. These two lines should be reversed. This works fine with the default --layers=false

Steps to reproduce the issue:

FROM php:7.2 
COPY --from=composer:latest /usr/bin/composer /usr/local/bin/composer

# buildah bud  --layers=true -f ~/Dockerfile.copyfrom -t tom .

Describe the results you received:

STEP 3: COPY --from=composer:latest /usr/bin/composer /usr/local/bin/composer
--> a026737dd9b91afbd7aa712f0e164bfd9ce9a2640555c920e2518f89133c0e76
STEP 4: COMMIT tom

Describe the results you expected:

STEP 3: COPY --from=composer:latest /usr/bin/composer /usr/local/bin/composer
STEP 4: COMMIT tom
--> a026737dd9b91afbd7aa712f0e164bfd9ce9a2640555c920e2518f89133c0e76

Output of buildah version:

(paste your output here)

Output of podman version if reporting a podman build issue:

# buildah version
Version:         1.6-dev
Go Version:      go1.10.4
Image Spec:      1.0.0
Runtime Spec:    1.0.0
CNI Spec:        0.4.0
libcni Version:  v0.7.0-alpha1
Git Commit:      de7f480a
Built:           Fri Dec 14 06:53:58 2018
OS/Arch:         linux/amd64

Output of cat /etc/*release:

# cat /etc/*release
Fedora release 28 (Twenty Eight)
NAME=Fedora
VERSION="28 (Server Edition)"
ID=fedora
VERSION_ID=28
PLATFORM_ID="platform:f28"
PRETTY_NAME="Fedora 28 (Server Edition)"
ANSI_COLOR="0;34"
CPE_NAME="cpe:/o:fedoraproject:fedora:28"
HOME_URL="https://fedoraproject.org/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=28
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=28
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Server Edition"
VARIANT_ID=server
Fedora release 28 (Twenty Eight)
Fedora release 28 (Twenty Eight)

Output of uname -a:

# uname -a
Linux localhost.localdomain 4.18.17-200.fc28.x86_64 #1 SMP Mon Nov 5 18:04:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
@rhatdan
Copy link
Member

rhatdan commented Mar 8, 2019

@TomSweeneyRedHat Is this still an issue?

@TomSweeneyRedHat
Copy link
Member Author

Yep, I'll see if I can squish it today.

TomSweeneyRedHat added a commit to TomSweeneyRedHat/buildah that referenced this issue Mar 8, 2019
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>

When the --layers option is used, the final imageID was
not being printed in the final line.  It was printed two
lines prior.  We still have to print the one two lines up
(at least without major modifications), but now we print
it in the last line as it does for all other circumstances
so it can be grabbed by scripts.

Fixes: containers#1237

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants