vendor latest openshift/imagebuilder #1390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrothberg
force-pushed
the
ci-test-imagebuilder
branch
5 times, most recently
from
d6a49c9
to
0dca4b4
Compare
openshift/imagebuilder had a dependency on a deprecated package that is now forked into imagebuilder to allow using more recent versions of docker/docker. Also vendor the latest docker/docker to a) demonstrate that imagebuilder does not force using an old version docker/docker and to b) pull in fixes and updates to our dependencies on docker/docker. See openshift/imagebuilder#125 for more details on the imagebuilder change. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
vrothberg
force-pushed
the
ci-test-imagebuilder
branch
from
0dca4b4
to
45ac4fc
Compare
vrothberg
changed the title
vrothberg
changed the title
|
The PR has been merged into imagebuilder. We can now use the latest version of docker/docker (if desired). Once this PR is merged, we should take it over to libpod rather quickly to not forget about updating the dependencies. |
It looks like the latest `vndr` wants to pull in more files than before. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
|
LGTM and passes baseline tests. |
|
📌 Commit 3377253 has been approved by |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 12, 2019
It looks like the latest `vndr` wants to pull in more files than before. Signed-off-by: Valentin Rothberg <rothberg@redhat.com> Closes: #1390 Approved by: rhatdan
|
☀️ Test successful - status-papr, status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openshift/imagebuilder had a dependency on a deprecated package that is
now forked into imagebuilder to allow using more recent versions of
docker/docker.
Also vendor the latest docker/docker to a) demonstrate that imagebuilder
does not force using an old version docker/docker and to b) pull in
fixes and updates to our dependencies on docker/docker.
See openshift/imagebuilder#125 for more details
on the imagebuilder change.
Signed-off-by: Valentin Rothberg rothberg@redhat.com