set $HOME to /root on chroot-isolation #2057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boaz0
changed the title
rhatdan
reviewed
Jan 3, 2020
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
|
LGTM |
|
📌 Commit 597eb97 has been approved by |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jan 7, 2020
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com> Closes: #2057 Approved by: rhatdan
|
💥 Test timed out |
|
@rh-atomic-bot retry |
|
☀️ Test successful - status-papr, status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2005
When isolation is set to chroot we are passing to
chroot.RunUsingChrootthehomeDirargument which is given byconfigureUIDGIDthat eventually gets it fromchroot.GetUser.In
chroot.GetUserthe default homeDir is set to/which that's why the$HOMEenv variable is/when using chroot isolation.