Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Containerfiles - smaller set of userns u/gids #3056

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

tetchel
Copy link
Contributor

@tetchel tetchel commented Mar 3, 2021

Signed-off-by: Tim Etchells tetchel@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Uses a range of user/group IDs with smaller numbers so the container does not run out

How to verify it

Build container image from these dockerfiles, run them with --user build, run buildah bud and have it succeed

Which issue(s) this PR fixes:

Fixes #3053

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- Container images - Fix newuidmap/newgidmap problems when running as a nonroot user by using a smaller UID/GID range.

Signed-off-by: Tim Etchells <tetchel@gmail.com>
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 3, 2021
@rhatdan
Copy link
Member

rhatdan commented Mar 3, 2021

This allows buildah containers to be used in rootless containers.
LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: tetchel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat
Copy link
Member

LGTM
Thanks @tetchel !

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 7989518 into containers:master Mar 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved kind/bug Categorizes issue or PR as related to a bug. lgtm locked - please file new issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rootless buildah/stable image not working
5 participants