-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump 1.23.0 #3516
Bump 1.23.0 #3516
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Are we planning to cut a v1.23.1 from the main branch later? If not, this should leave it marked as v1.24.0-dev. |
@@ -83,7 +83,7 @@ epoch_commit() | |||
} | |||
|
|||
git fetch origin && | |||
git checkout -b "bump-${VERSION}" origin/master && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch, wonder how this slipped through?
Need to update CHANGELOG.md too |
And you need to add "NO TESTS NEEDED" to the description, my nemesis. |
[NO TESTS NEEDED] Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
[NO TESTS NEEDED] Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
e1fcd89
to
5fbfcf9
Compare
LGTM |
Fedora 33 w/overlay isn't happy, I don't think it's a flake.
|
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?