Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump 1.23.0 #3516

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Bump 1.23.0 #3516

merged 2 commits into from
Sep 14, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Sep 13, 2021

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nalind
Copy link
Member

nalind commented Sep 13, 2021

Are we planning to cut a v1.23.1 from the main branch later? If not, this should leave it marked as v1.24.0-dev.

@@ -83,7 +83,7 @@ epoch_commit()
}

git fetch origin &&
git checkout -b "bump-${VERSION}" origin/master &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, wonder how this slipped through?

@TomSweeneyRedHat
Copy link
Member

Need to update CHANGELOG.md too

@TomSweeneyRedHat
Copy link
Member

And you need to add "NO TESTS NEEDED" to the description, my nemesis.

[NO TESTS NEEDED]

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
[NO TESTS NEEDED]

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

Fedora 33 w/overlay isn't happy, I don't think it's a flake.

[+1146s] # time="2021-09-13T16:54:07-05:00" level=error msg="A layer is mounted: layer is in use by a container"
[+1146s] # $ /var/tmp/go/src/github.com/containers/buildah/tests/./../bin/buildah from --signature-policy /var/tmp/go/src/github.com/containers/buildah/tests/./policy.json --quiet --userns-uid-map-user=foo --userns-gid-map-group=fedora alpine
[+1146s] # alpine-working-container-5
[+1146s] # $ /var/tmp/go/src/github.com/containers/buildah/tests/./../bin/buildah run --cni-config-dir=/var/tmp/buildah_tests.kgodn2/no-cni-configs alpine-working-container-5 readlink /proc/self/ns/user
[+1146s] # user:[4026532328]
[+1146s] # $ /var/tmp/go/src/github.com/containers/buildah/tests/./../bin/buildah run --cni-config-dir=/var/tmp/buildah_tests.kgodn2/no-cni-configs alpine-working-container-5 cat /proc/self/uid_map
[+1146s] #          0     165536      65536
[+1146s] # $ /var/tmp/go/src/github.com/containers/buildah/tests/./../bin/buildah run --cni-config-dir=/var/tmp/buildah_tests.kgodn2/no-cni-configs alpine-working-container-5 cat /proc/self/gid_map
[+1146s] #          0     231072      65536
[+1146s] #      65536     296608      65536
[+1146s] # #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
[+1146s] # #|     FAIL: gid_map
[+1146s] # #| expected: '0 231072
[+1146s] # 296608 65536'
[+1146s] # #|   actual: '0 231072 65536'
[+1146s] # #|         > '65536 296608 65536'
[+1146s] # #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[+1146s] # /var/tmp/go/src/github.com/containers/buildah/tests

@rhatdan rhatdan added the lgtm label Sep 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit 69b3e56 into containers:main Sep 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants