Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to github.com/vbauerster/mpb v7.1.5 #3526

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Sep 20, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

Update to github.com/vbauerster/mpb v7.1.5 to fix vbauerster/mpb#100 .

go get github.com/vbauerster/mpb/v7@latest
make vendor

How to verify it

? Hope that occasional CI hangs go away. Rely on Podman reliably reproducing the hang with MPB 7.1.3, and it being fixed in this version.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

... to fix vbauerster/mpb#100 .

> go get github.com/vbauerster/mpb/v7@latest
> make vendor

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 20, 2021
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@rhatdan @nalind PTAL

@nalind
Copy link
Member

nalind commented Sep 20, 2021

LGTM

1 similar comment
@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm

@rhatdan
Copy link
Member

rhatdan commented Sep 20, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4c287d1 into containers:main Sep 20, 2021
@mtrmac mtrmac deleted the mpb branch September 22, 2021 16:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved kind/bug Categorizes issue or PR as related to a bug. lgtm locked - please file new issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deadlock in Bar.serve-> Progress.dropBar vs. Progress.serve -> Bar.*
6 participants