conformance: allow test cases to specify dockerUseBuildKit #3529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
reviewed
Sep 21, 2021
| @@ -32,6 +32,9 @@ import ( | |||
| "github.com/containers/image/v5/types" | |||
| "github.com/containers/storage" | |||
| "github.com/containers/storage/pkg/reexec" | |||
| dockertypes "github.com/docker/docker/api/types" | |||
| dockerdockerclient "github.com/docker/docker/client" | |||
There was a problem hiding this comment.
We already have imports named client, docker, and dockerclient, so I'm running out of pseudonyms for them.
There was a problem hiding this comment.
Well, client's a variable, not a package.
|
LGTM |
nalind
force-pushed
the
conformance-allow-buildkit
branch
3 times, most recently
from
b0f0041
to
d6d23b5
Compare
The API flag that we'd need to set to in a build request to get dockerd use BuildKit instead of the classic docker builder isn't available in go-dockerclient, so add a second docker-based path that uses the API types and client library, which the conformance tests were already pulling in as indirect dependencies, but skip tests that set the flag if we're not on the current client version. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
conformance-allow-buildkit
branch
from
d6d23b5
to
fab0d64
Compare
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
The API flag that we'd need to set to in a build request to get dockerd use BuildKit instead of the classic docker builder isn't available in go-dockerclient, so add a second docker-based path that uses the API types and client library, which the conformance tests were already pulling in as indirect dependencies, but skip tests that set the flag if we're not on the current client version.
This is mainly groundwork for testing compatibility, in the future, with features that aren't in the docker classic builder.
How to verify it
New conformance test!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?