push: support to specify the compression format #3532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Does this work with every transport? |
|
I've tested it with |
nalind
reviewed
Sep 22, 2021
giuseppe
force-pushed
the
support-compression-format-level
branch
from
706d2a3
to
2f8ec4b
Compare
giuseppe
force-pushed
the
support-compression-format-level
branch
from
2f8ec4b
to
7fa21cf
Compare
add two new flags to "buildah push" to allow tweaking the compression format for the data layers. The flag --compression-format allows users to specify the compression algorithm to use. With --compression-level it is possible to tweak the compression level. An image usage for partial pulls can be pushed with: $ buildah push --compression-format zstd:chunked FOO Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
support-compression-format-level
branch
from
7fa21cf
to
1cc85e7
Compare
|
LGTM |
vrothberg
reviewed
Sep 23, 2021
|
/hold cancel |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add two new flags to "buildah push" to allow tweaking the compression
format for the data layers.
The flag --compression-format allows users to specify the compression
algorithm to use.
With --compression-level it is possible to tweak the compression
level.
An image usage for partial pulls can be pushed with:
$ buildah push --compression-format zstd:chunked FOO
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
It allows users to specify the compression for the image data layers.
How to verify it
buildah push --compression-format zstd:chunked FOO dir:/tmp/foo
The files under /tmp/foo are compressed with zstd.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?