Makefile: check for -race using -mod=vendor
#3535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When checking if `go test` supports `-race` on the current platform, use `-mod=vendor` if it's available, so that the compiler won't try to pull down our dependencies, and run it against a package that has fewer dependencies. Run `go tool dist list` once, and filter its results to derive the cross-compile target lists, rather than running it three times. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
LGTM |
|
LGTM |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
When checking if
go testsupports-raceon the current platform, use-mod=vendorif it's available, so that the compiler won't try to pull down our dependencies, and run it against a package that has fewer dependencies.Run
go tool dist listonce, and filter its results to derive the cross-compile target lists, rather than running it three times.How to verify it
Running
makeshould be at least a bit faster.Which issue(s) this PR fixes:
Fixes #3534
Special notes for your reviewer:
Does this PR introduce a user-facing change?