Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: adjust -ldflags/-gcflags/-gccgoflags depending on the go implementation #3538

Merged

Conversation

dilyanpalauzov
Copy link
Contributor

No description provided.

…plementation

Insisting on “DCO” imposes formalities, that serve self-purpose.  One cannot
assume that the submitter has time or will to read texts about symbolism in
software contributions.  If the system wants to see the text

  nrEAUIEUAIe eanuitdnuae EAIUEAUIAIE »ℓ§444.3.72b)°»°ℓ§euaieauuae

in each commit, people will write this, or any other text, that the system wants to
see.  All such text, which presence is mandated by the system, has the same value.

[NO TESTS NEEDED]

Signed-off-by: Дилян Палаузов <git-dpa@aegee.org>
@rhatdan
Copy link
Member

rhatdan commented Sep 24, 2021

LGTM

@nalind
Copy link
Member

nalind commented Sep 24, 2021

LGTM. Thanks!

@rhatdan
Copy link
Member

rhatdan commented Sep 24, 2021

/approve
/lgtm
/hold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dilyanpalauzov, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit 5b0de7b into containers:main Sep 25, 2021
@dilyanpalauzov dilyanpalauzov deleted the makefile_gccgoflags branch September 25, 2021 17:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants