Bump containerd to v1.5.7 #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have/need a |
Fixes: GHSA-c2h3-6mxw-7mvq Vulnerable versions: >= 1.5.0, < 1.5.7 Patched version: 1.5.7 `Impact` A bug was found in containerd where container root directories and some plugins had insufficiently restricted permissions, allowing otherwise unprivileged Linux users to traverse directory contents and execute programs. When containers included executable programs with extended permission bits (such as setuid), unprivileged Linux users could discover and execute those programs. When the UID of an unprivileged Linux user on the host collided with the file owner or group inside a container, the unprivileged Linux user on the host could discover, read, and modify those files. `Patches` This vulnerability has been fixed in containerd 1.4.11 and containerd 1.5.7. Users should update to these version when they are released and may restart containers or update directory permissions to mitigate the vulnerability. `Workarounds` Limit access to the host to trusted users. Update directory permission on container bundles directories. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
BTW This Vulnerability looks like it did not effect Buildah. |
|
@rhatdan ack, now that you mention it, I think I remember someone else saying something to that effect. But I was seeing that annoying github security warning, hence the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: GHSA-c2h3-6mxw-7mvq
Vulnerable versions: >= 1.5.0, < 1.5.7
Patched version: 1.5.7
ImpactA bug was found in containerd where container root directories and
some plugins had insufficiently restricted permissions, allowing
otherwise unprivileged Linux users to traverse directory contents
and execute programs. When containers included executable programs
with extended permission bits (such as setuid), unprivileged Linux
users could discover and execute those programs. When the UID of
an unprivileged Linux user on the host collided with the file
owner or group inside a container, the unprivileged Linux user on
the host could discover, read, and modify those files.
PatchesThis vulnerability has been fixed in containerd 1.4.11 and
containerd 1.5.7. Users should update to these version when they
are released and may restart containers or update directory
permissions to mitigate the vulnerability.
WorkaroundsLimit access to the host to trusted users. Update directory
permission on container bundles directories.
Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org
What type of PR is this?
What this PR does / why we need it:
Fix for GHSA-c2h3-6mxw-7mvq
How to verify it
Check if containerd v1.5.7 is correctly vendored (I think)
Which issue(s) this PR fixes:
Fixes GHSA-c2h3-6mxw-7mvq
Special notes for your reviewer:
Does this PR introduce a user-facing change?
None
@nalind @vrothberg @TomSweeneyRedHat @rhatdan PTAL