[CI:DOCS] De-dockerize the man page as much as possible #3579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
flouthoc
reviewed
Oct 11, 2021
| @@ -139,7 +139,7 @@ Buildah can set up environment variables from the env entry in the [engine] tabl | |||
| | Command | Man Page | Description | | |||
| | ---------- | ------------------------------------------------ | ---------------------------------------------------------------------------------------------------- | | |||
| | add | [buildah-add(1)](buildah-add.1.md) | Add the contents of a file, URL, or a directory to the container. | | |||
| | build | [buildah-build(1)](buildah-build.1.md) | Build an image using instructions from Dockerfiles. | | |||
| | build | [buildah-build(1)](buildah-build.1.md) | Builds an OCI image using instructions in one or more Containerfiles. | | |||
There was a problem hiding this comment.
Sorry for late review since PR is merged. @rhatdan does this makes it sound it that build is exclusive to OCI ? However build supports building both docker and oci format but defaults to oci.
There was a problem hiding this comment.
I don't believe this is really an issue, if the primary use case is to build OCI images.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?