Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Include manifest example usage #3582

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

cevich
Copy link
Member

@cevich cevich commented Oct 11, 2021

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This duplicates containers/podman#11889 which is
annoying, but there seems no easy way to avoid it. The
commands/examples have been 'translated' for Buildah.

How to verify it

Documentation change must be manually verified.

Which issue(s) this PR fixes:

Fixes containers/podman#8872

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

This duplicates containers/podman#11889 which is
annoying, but there seems no easy way to avoid it.  The
commands/examples have been 'translated' for Buildah.

Signed-off-by: Chris Evich <cevich@redhat.com>
@openshift-ci openshift-ci bot added kind/documentation Categorizes issue or PR as related to documentation. approved labels Oct 11, 2021
@TomSweeneyRedHat
Copy link
Member

LGTM

@rhatdan
Copy link
Member

rhatdan commented Oct 12, 2021

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7a0870c into containers:main Oct 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved kind/documentation Categorizes issue or PR as related to documentation. lgtm locked - please file new issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Documentation for How to Use Manifests
4 participants