docs: Use guaranteed path for go-md2man #3610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its not guaranteed that host contains go-md2man so use the one which is built by buildah. Signed-off-by: Aditya Rajan <arajan@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rhatdan @TomSweeneyRedHat Just a small revert. |
|
LGTM |
| @@ -1,7 +1,8 @@ | |||
| PREFIX := /usr/local | |||
| DATADIR := ${PREFIX}/share | |||
| MANDIR := $(DATADIR)/man | |||
| GOMD2MAN ?= $(shell command -v go-md2man || echo '$(GOBIN)/go-md2man') | |||
| # Following go-md2man is guaranteed on host | |||
| GOMD2MAN ?= ../tests/tools/build/go-md2man | |||
There was a problem hiding this comment.
I'm not seeing the build directory in upstream. Is this getting built somewhere? Should we instead use ./tests/tools/vendor/github.com/cpuguy83/go-md2man or maybe add the two directories to the old command as or's?
There was a problem hiding this comment.
@TomSweeneyRedHat its generated by the make
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its not guaranteed that host contains go-md2man so use the one which is
built by buildah.
Closes: #3556