Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Fix tutorial to specify command on buildah run line #3613

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Nov 4, 2021

Fixes: #3564

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@openshift-ci openshift-ci bot added the approved label Nov 4, 2021
@rhatdan rhatdan changed the title Fix tutorial to specify command on buildah run line [CI:DOCS] Fix tutorial to specify command on buildah run line Nov 4, 2021
Fixes: containers#3564

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
Copy link
Member Author

rhatdan commented Nov 4, 2021

@brlin-tw PTAL

@rhatdan
Copy link
Member Author

rhatdan commented Nov 5, 2021

@flouthoc
Copy link
Collaborator

flouthoc commented Nov 5, 2021

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Nov 5, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7017fc8 into containers:main Nov 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to reproduce a running container right after buildah run $httpcontainer in Tutorial 1
3 participants