define.TempDirForURL(): show CombinedOutput when a command fails #3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When define.TempDirForURL() runs an external command, if it fails, include the command's output in the error that's handed back to its caller so that the end-user has some idea of what happened. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
h/t @edsantiago @cevich |
|
It's for the vague error message you asked about in chat last week. |
|
LGTM |
|
Oh, I remember now. LGTM, thank you! |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
When
define.TempDirForURL()runs an external command, if it fails, include the command's output in the error that's handed back to its caller so that the end-user has some idea of what happened.How to verify it
New integration test!
Which issue(s) this PR fixes:
Out-of-band error report.
Special notes for your reviewer:
We really need to stop adding logic to the
definepackage. It drags additional dependencies in for consumers of the package that only want our type definitions, which directly undermines the stated rationale for creating thedefinepackage and moving type definitions into it.Does this PR introduce a user-facing change?