Tests should rely only on static/unchanging images #3640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Around 18th of Nov. 2021, a new/incompatible `quay.io/libpod/fedora-minimal:latest` was pushed by the quay auto-builder servicing the podman repo. This caused a number of problems across several branches. To address this, the auto-builder was disabled and a fixed F34 based image was tagged and pushed as both `latest` and `34`. However, all repositories which use this test image need to be individually updated to reference it. See containers/podman#12343 Signed-off-by: Chris Evich <cevich@redhat.com>
openshift-ci
bot
added
kind/flake
|
/lgtm |
edsantiago
approved these changes
Nov 19, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind flake
What this PR does / why we need it:
Around 18th of Nov. 2021, a new/incompatible
quay.io/libpod/fedora-minimal:latestwas pushed by the quayauto-builder servicing the podman repo. This caused a number of
problems across several branches. To address this, the auto-builder was
disabled and a fixed F34 based image was tagged and pushed as both
latestand34. However, all repositories which use this test imageneed to be individually updated to reference it.
See containers/podman#12343
How to verify it
CI will pass
Which issue(s) this PR fixes:
None filed
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
None