Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: accept multiple filter with logical AND between them. #3651

Merged

Conversation

flouthoc
Copy link
Collaborator

@flouthoc flouthoc commented Nov 29, 2021

Already documented but a NOOP currently buildah images accepts a
single filter however it should accept multiple filters and perform a
logical AND between them while fetching images.

buildah images --filter <1> --filter <2>

Closes: #3649

Already documented but a NOOP currently `buildah images` accepts a
single filter however it should accept multiple filters and perform a
logical `AND` between them while fetching images.

`buildah images --filter <1> --filter <2>`

Signed-off-by: Aditya Rajan <arajan@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flouthoc
Copy link
Collaborator Author

@nalind @giuseppe @rhatdan PTAL

@rhatdan
Copy link
Member

rhatdan commented Nov 29, 2021

/lgtm
Nice one @flouthoc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

only last image filters takes effect when list images with buildah
4 participants