Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Simple README fix #3654

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

MaximUltimatum
Copy link
Contributor

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design

/kind documentation

/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it: One word grammar fix. Appreciated the documentation so helping to improve it.

How to verify it

Which issue(s) this PR fixes: Just a quick grammar fix. Commit is unsigned, I haven't gotten that set up yet. If that's an issue just close this PR and have someone else make the change the next time something is merged.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 29, 2021
@rhatdan
Copy link
Member

rhatdan commented Nov 29, 2021

@MaximUltimatum Thanks for the PR, could you sign it?

git commit -a --amend -s
git push --force

LGTM
/approve

Signed-off-by: MaximUltimatum <mcder018@live.com>
@MaximUltimatum
Copy link
Contributor Author

rhatdan I got the signing set up but now my commit is showing up as verified. Would you still like me to try to sign it?

@rhatdan
Copy link
Member

rhatdan commented Nov 29, 2021

Squash your commits.

git rebase -i origin
git push --force

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @MaximUltimatum !

@MaximUltimatum
Copy link
Contributor Author

MaximUltimatum commented Dec 1, 2021

@rhatdan Done. Anything else I can do? I'm getting a notice status that it's out of date with the base branch. Do I need to resolve that somehow?

@rhatdan rhatdan changed the title Simple README fix [ci:docs] Simple README fix Dec 1, 2021
@rhatdan
Copy link
Member

rhatdan commented Dec 1, 2021

Nope looks great Thanks.
/lgtm
/approve
/hold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaximUltimatum, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nalind nalind changed the title [ci:docs] Simple README fix [CI:DOCS] Simple README fix Dec 2, 2021
@rhatdan
Copy link
Member

rhatdan commented Dec 3, 2021

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit 080d839 into containers:main Dec 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved kind/documentation Categorizes issue or PR as related to documentation. lgtm locked - please file new issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants