-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] Simple README fix #3654
Conversation
@MaximUltimatum Thanks for the PR, could you sign it? git commit -a --amend -s LGTM |
Signed-off-by: MaximUltimatum <mcder018@live.com>
rhatdan I got the signing set up but now my commit is showing up as verified. Would you still like me to try to sign it? |
Squash your commits. git rebase -i origin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @MaximUltimatum !
a5ef55a
to
2c366d1
Compare
@rhatdan Done. Anything else I can do? I'm getting a notice status that it's out of date with the base branch. Do I need to resolve that somehow? |
Nope looks great Thanks. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MaximUltimatum, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What type of PR is this?
/kind documentation
What this PR does / why we need it: One word grammar fix. Appreciated the documentation so helping to improve it.
How to verify it
Which issue(s) this PR fixes: Just a quick grammar fix. Commit is unsigned, I haven't gotten that set up yet. If that's an issue just close this PR and have someone else make the change the next time something is merged.
Special notes for your reviewer:
Does this PR introduce a user-facing change?