tests: move buildkit mount tests files from TESTSDIR to TESTDIR before any modifications
#3670
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -3641,67 +3641,75 @@ _EOF | |||
| @test "bud-with-mount-like-buildkit" { | |||
| skip_if_no_runtime | |||
| skip_if_in_container | |||
| run_buildah build -t testbud --signature-policy ${TESTSDIR}/policy.json -f ${TESTSDIR}/bud/buildkit-mount/Dockerfile ${TESTSDIR}/bud/buildkit-mount/ | |||
| cp -R ${TESTSDIR}/bud/buildkit-mount ${TESTDIR}/buildkit-mount | |||
| run_buildah build -t testbud --signature-policy ${TESTSDIR}/policy.json -f ${TESTDIR}/buildkit-mount/Dockerfile ${TESTDIR}/buildkit-mount/ | |||
There was a problem hiding this comment.
The policy.json still has a TESTSDIR.
There was a problem hiding this comment.
@rhatdan Tests don't modify policy so i didn't move it and its same for all the other old tests as well.
…e modification In certain environments tests are conducted from `/usr` where `selinux` blocks certain operation so move all files where modifications are expected from `$TESTSDIR` to `$TESTDIR` Signed-off-by: Aditya Rajan <arajan@redhat.com>
flouthoc
force-pushed
the
buildkit-refactor-tests
branch
from
1e5c1f2
to
c7c75bd
Compare
|
LGTM |
|
This is the approach I was envisioning. Future maintainers might've been grateful for helpful comments by the /lgtm |
In certain environments tests are conducted from
/usrwhereselinuxblocks certain operation so move all files where modifications are
expected from
$TESTSDIRto$TESTDIRCloses: #3667