use libnetwork from c/common for networking #3690
Conversation
openshift-ci
bot
added
the
kind/feature
Luap99
force-pushed
the
network
branch
2 times, most recently
from
de71103
to
79e9cbb
Compare
|
Assuming it passes tests, this looks reasonable. |
Luap99
force-pushed
the
network
branch
2 times, most recently
from
22f32b2
to
3c2e420
Compare
|
Changes look reasonable to me, but the test system isn't at all happy and you need a rebase here. |
|
Yeah that is a regression in c/common, I opened containers/common#875 to revert the change for now. |
Do not configure the netns in the runtime child process, this removes the need to send the network options to the child. This will be needed for the new libnetwork network interface which cannot be transfered as json. To synchronize this between the child and parent we use two pipe pairs. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Podman uses the new netavark network stack. Buildah should be able to do the same. Both projects should use the same networking code which was move to c/common/libnetwork. The new network interface can use either CNI or netvavark. Using the same code for podman and buildah is important to ensure that both use the same backend. Mixing CNI and netavark is not supported. This also fixes some outstanding CNI issues, e.g. buildah trying to connect all cni networks. [NO NEW TESTS NEEDED] Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
/lgtm |
|
/hold cancel |
|
@Luap99 After this PR My builds are failing with Edit: Rootless builds |
|
Ah sorry, is there no rootless testing in CI? |
|
No issues not urgent i am still able to do work with |
What type of PR is this?
/kind feature
What this PR does / why we need it:
setup the netns in the buildah parent process
Do not configure the netns in the runtime child process, this removes
the need to send the network options to the child. This will be needed
for the new libnetwork network interface which cannot be transfered as
json.
To synchronize this between the child and parent we use two pipe pairs.
use libnetwork from c/common for networking
Podman uses the new netavark network stack. Buildah should be able to do
the same. Both projects should use the same networking code which was
move to c/common/libnetwork. The new network interface can use either
CNI or netvavark. Using the same code for podman and buildah is
important to ensure that both use the same backend. Mixing CNI and
netavark is not supported.
This also fixes some outstanding CNI issues, e.g. buildah trying to
connect all cni networks.
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?