Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow processing of common options via FlagSet #3692

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

abergmeier
Copy link
Contributor

@abergmeier abergmeier commented Jan 7, 2022

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake
/kind other

What this PR does / why we need it:

Am using Buildah - but don't want to use Cobra.

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress kind/feature Categorizes issue or PR as related to a new feature. labels Jan 7, 2022
@TomSweeneyRedHat
Copy link
Member

@abergmeier thanks for the change, but our CI isn't thrilled with it...

[+0071s] # github.com/containers/buildah/pkg/parse
[+0071s] pkg/parse/parse.go:61:39: undefined: pflag
[+0071s] pkg/parse/parse.go:122:19: undefined: c
[+0071s] pkg/parse/parse.go:128:35: undefined: c
[+0071s] pkg/parse/parse.go:135:18: undefined: c
[+0071s] pkg/parse/parse.go:136:17: undefined: c
[+0071s] pkg/parse/parse.go:137:18: undefined: c
[+0071s] pkg/parse/parse.go:138:18: undefined: c
[+0071s] pkg/parse/parse.go:141:5: undefined: flag
[+0071s] pkg/parse/parse.go:152:17: undefined: c
[+0071s] pkg/parse/parse.go:153:17: undefined: c
[+0071s] pkg/parse/parse.go:153:17: too many errors

@abergmeier abergmeier force-pushed the patch-1 branch 3 times, most recently from c2ab966 to 07a4efb Compare January 10, 2022 05:42
In situations where you don't want/need Cobra climbing behavior nor
Cobra at all using FlagSet is the easier sell.

Signed-off-by: Andreas Bergmeier <abergmeier@gmx.net>
@rhatdan
Copy link
Member

rhatdan commented Jan 11, 2022

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rhatdan
Copy link
Member

rhatdan commented Jan 11, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abergmeier, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 50498df into containers:main Jan 11, 2022
@abergmeier abergmeier deleted the patch-1 branch January 11, 2022 19:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved kind/feature Categorizes issue or PR as related to a new feature. lgtm locked - please file new issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants