executor: Share selinux (process and mount) label of first stage with other stages in same build
#3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flouthoc
changed the title
selinux (process and mount) label of first stage with other stages in same buildselinux (process and mount) label of first stage with other stages in same build
flouthoc
force-pushed
the
share-selinux-label-across-stage
branch
from
5325a1d
to
204e2d2
Compare
|
LGTM |
flouthoc
force-pushed
the
share-selinux-label-across-stage
branch
from
204e2d2
to
d5dea4c
Compare
…uild Buildah `builds` are composed of various `stages`. That is each `stage` in a build is a `container`. As of now buildah does not provides any `processLabel` and `mountLabel` to the stage containers which results in `c/storage` assigning random generated `selinux` labels to each stage. If each stage has its own unqiue `processLabel` and `mountLabel` stages cannot be mounted across each other in the same build as `selinux` prevents that. We get the `processLabel` and `mountLabel` of the first stage created by the executor ( label assigned by `c/stoage` ) and share it with all the other subsequent stages of the same build. Signed-off-by: Aditya Rajan <arajan@redhat.com>
…abled Stage mounting was not functionl for systems with `selinux` enabled following commit makes sure we enable it and removes temporary workaround/hack which was preventing to do it. Signed-off-by: Aditya Rajan <arajan@redhat.com>
flouthoc
force-pushed
the
share-selinux-label-across-stage
branch
from
d5dea4c
to
5c26f71
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This should also close: #3501 completely |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do we need this ?
Buildah
buildsare composed of variousstages. That is eachstagein a build is acontainer.As of now buildah does not provides any
processLabelandmountLabelto the stage container whichresults in
c/storageassigning random generatedselinuxlabels to each stage.As a result this PR also enables following feature on systems with
selinuxenabled: #3590Problem
If each stage has its own unqiue
processLabelandmountLabelstages cannot be mounted across each otherin the same build.
selinuxprevents that.Solution
We get the
processLabelandmountLabelof the first stage created by the container i.e assigned byc/stoageand share it with all the other subsequent stages of the same build.