Tests tools bump #3723
Merged
Tests tools bump #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
kind/cleanup
kolyshkin
force-pushed
the
tests-tools-bump
branch
from
4d7cbf1
to
ce8bc12
Compare
|
I have had temporary commit added to check if the new subject line length check it working, and it is! (see |
kolyshkin
force-pushed
the
tests-tools-bump
branch
from
ce8bc12
to
1c14fbb
Compare
|
LGTM |
|
/lgtm |
|
LGTM |
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
1. Remove GO111MODULE=on and -mod=vendor. Those are not required (default) since go 1.16 (or earlier), and go 1.16 is currently the oldest supported release. 2. Remove go-build define: - cd `pwd` does not make any sense; - @echo > /dev/null masks any errors during tools building; - $(shell basename ...) could be replaced by $(notdir ...); - the above is not needed since we already have what we need as a target ($@); - finally, this is problematic for e.g. cpuguy83/go-md2man/v2 (as it builds the binary named v2). So, just use $(GO_BUILD) -o $@ path/to/package 3. GO_BUILD does not need to be exported. 4. Mark $(BUILDDIR) target as phony -- a mere existence of the directory should not cause make to skip building the binaries. K.I.S.S! Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Currently, git-validation is used to do two things: 1. Check that all commits in a PR has DCO (Signed-off-by) 2. Check that all commits has limited subject length Nowdays, there are better tools for that. For DCO, https://github.com/apps/dco can be used, and for subject length check, I mocked up a GHA CI job (originally in opencontainers/runc -- copied from there with some minimal changes). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
tests-tools-bump
branch
from
1c14fbb
to
8b190fe
Compare
|
rebased |
|
@cevich PTAL |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
What this PR does / why we need it:
Some vendoring bumps and simplifications for tests/tools.
This is a followup to #3717, addressing TODO in #3717 (comment) and a few more things (see individual commits for details).
How to verify it
CI should be sufficient
Which issue(s) this PR fixes:
none
Special notes for your reviewer:
Please review commit-by-commit, and see individual commit messages for details.
Does this PR introduce a user-facing change?