Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor in latest containers/common #3727

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jan 20, 2022

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@TomSweeneyRedHat
Copy link
Member

@rhatdan, unhappy tests and it might be a real issue:

[+0792s] # ef17c8d7b8a99fde5210ec021070cd469848766c11d849960a00fb9ae5d24c4f
[+0792s] # error building at STEP "COPY --from=0 /root/Dockerfile.no-run /root/": checking on sources under "/var/tmp/buildah_tests.birhhw/root/overlay/2b7c1e03ab5d5507c47ad02124618728ec4a331e3d7b45bc8ed4c8e008b89479/merged": error in copier subprocess: error changing to intended-new-root directory "/var/tmp/buildah_tests.birhhw/root/overlay/2b7c1e03ab5d5507c47ad02124618728ec4a331e3d7b45bc8ed4c8e008b89479/merged": chdir /var/tmp/buildah_tests.birhhw/root/overlay/2b7c1e03ab5d5507c47ad02124618728ec4a331e3d7b45bc8ed4c8e008b89479/merged: no such file or directory

@rhatdan rhatdan changed the title Vendor in latest containers/storage and containers/image Vendor in latest containers/storage and containers/common Jan 20, 2022
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan rhatdan changed the title Vendor in latest containers/storage and containers/common Vendor in latest containers/common Jan 21, 2022
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, lsm5, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [giuseppe,lsm5,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Jan 21, 2022
@openshift-merge-robot openshift-merge-robot merged commit 9c2f1a7 into containers:main Jan 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants