[CI:DOCS] Fix typos and improve language #3745
Conversation
Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
|
Maybe I shouldn't have added the |
| @@ -216,7 +216,7 @@ The secret needs to be passed to the build using the --secret flag. The final im | |||
| If you use the shell form of the **CMD**, the `<command>` executes in `/bin/sh -c`: | |||
|
|
|||
| Note that the exec form is parsed as a JSON array, which means that you must | |||
| use double-quotes (") around words not single-quotes ('). | |||
| use double-quotes (") around words, not single-quotes ('). | |||
There was a problem hiding this comment.
Just noting that #3746 and containers/common#905 are moving this file from Buildah to c/common. We should ensure these changes move too. @Foxboron FYI
There was a problem hiding this comment.
I can produce a very ad-hoc patch and apply on top of my branch so @eriksjolund get author credit there :)
|
Awesome changes @eriksjolund TYVM! I'm really shocked by the "using using" bit in so many places. |
|
@TomSweeneyRedHat Feel free to merge these first. I'll do a rebase and include a patch with these changes (where relevant) on top of my change :) Thanks! |
Co-authored-by: Tom Sweeney <tsweeney@redhat.com>
|
Is there anything I should do? |
|
Could you pull both and merge them |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eriksjolund, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I decided to force merge. |
|
@rhatdan Thanks for merging |
Signed-off-by: Erik Sjölund erik.sjolund@gmail.com
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?