helpers.bash: Use correct syntax #3792
Conversation
|
@lsm5: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
is the |
lsm5
added
the
kind/failing-test
|
LGTM but the indentation is wonky (from an earlier commit). If for some reason you need to resubmit, would you mind replacing the tabs in those nearby lines with spaces? Also, how did this ever work? |
hmmmm, isn't the github diff tab supposed to show me that wonkiness? Maybe my editor did something weird. I'll check and resubmit.
Did something change in bash between rhel 8 and f35 ?? |
|
ah earlier commit. ack |
Fixes gating test failure: ``` /usr/share/buildah/test/system/./helpers.bash: line 474: !is_cgroupsv2: command not found ``` Co-authored-by: Yiqiao Pu <ypu@redhat.com> I'm just the committer. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
lsm5
force-pushed
the
fix-bash-syntax
branch
from
3ee748f
to
eedab4f
Compare
|
@edsantiago PTAL now. thanks. @ypu credited you in the commit. Thanks! |
|
/lgtm |
|
/hold cancel |
Fixes gating test failure:
From: Yiqiao Pu ypu@redhat.com
I'm just the committer.
Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Fixes gating tests
How to verify it
Gating tests should not show that error.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
@edsantiago @nalind @rhatdan PTAL.