buildah: add support for renaming a device in rootless setups using --device
#4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
flouthoc
force-pushed
the
support-renaming-device-rootless
branch
from
a248648
to
a0c8327
Compare
|
LGTM |
flouthoc
force-pushed
the
support-renaming-device-rootless
branch
from
a0c8327
to
212d32e
Compare
|
LGTM |
Buildah now supports renaming devices while performing a build using `--device <some-name>:<new-name>`. Implementation is similar to `podman` where we prefer using `bind-mount` for devices instead of `mknod` in `rootless` setups. Usage ```console buildah build -t test --device /dev/null:/test/dev/null . ``` Closes: containers#4002 Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
force-pushed
the
support-renaming-device-rootless
branch
from
212d32e
to
b3fbb59
Compare
|
Rebased :) |
|
/lgtm |
|
/hold cancel |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buildah now supports renaming devices while performing a build using
--device <some-name>:<new-name>. Implementation is similar topodmanwhere we prefer using
bind-mountfor devices instead ofmknodinrootlesssetups.Usage
buildah build -t test --device /dev/null:/test/dev/null .Closes: #4002