Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constants from containers/common for finding seccomp.json #4225

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

nalind
Copy link
Member

@nalind nalind commented Sep 9, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Use values from containers/common for locating seccomp.json. At the moment this isn't actually a change, but we don't want to fall out of step again.

How to verify it

Tests should continue to pass.

Which issue(s) this PR fixes:

None, but it should prevent another #4219 later.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 9, 2022
Use values from containers/common for locating seccomp.json.  At the
moment this isn't actually a change, but we don't want to fall out of
step again.

[NO NEW TESTS NEEDED]

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@openshift-ci openshift-ci bot added the approved label Sep 9, 2022
@nalind nalind changed the title Use constants for containers/common for finding seccomp.json Use constants from containers/common for finding seccomp.json Sep 9, 2022
@rhatdan
Copy link
Member

rhatdan commented Sep 9, 2022

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/lgtm
/approve
/hold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat
Copy link
Member

LGTM
nice catch and fix @nalind

@TomSweeneyRedHat
Copy link
Member

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit 9e2b0e2 into containers:main Sep 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm locked - please file new issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants