makefile: increase conformance timeout #4760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Apr 26, 2023
flouthoc
force-pushed
the
increase-conformance-timeout
branch
from
e59c051
to
b505748
Compare
|
@nalind Any hints about why conformance is timing out in upstream recently ? |
|
@flouthoc Also needs a corresponding change in |
flouthoc
force-pushed
the
increase-conformance-timeout
branch
from
b505748
to
09cccb3
Compare
|
Okay CI passes with increased timeout, also did change in |
flouthoc
force-pushed
the
increase-conformance-timeout
branch
from
09cccb3
to
ec359a2
Compare
increase conformance timeout from `30min` -> `60min`. [NO NEW TESTS NEEDED] Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
force-pushed
the
increase-conformance-timeout
branch
from
ec359a2
to
5621727
Compare
|
/lgtm |
|
/unhold |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increase conformance timeout from
30min->60min.[NO NEW TESTS NEEDED]
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?