secret: accept required flag without value
#4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Buildkit` and `docker` accepts `required` flag as `true` in
`--mount=type=secret` so let do same for buildah.
Example usage
```Dockerfile
FROM docker.io/nginx:1.23.3
RUN --mount=type=secret,id=nginx-crt,dst=/nginx-repo.crt,required \
--mount=type=secret,id=nginx-key,dst=/nginx-repo.key,required \
set -x \
&& . /etc/os-release \
&& stat /nginx-repo.crt \
&& stat /nginx-repo.key
```
Closes: containers/podman#18438
Signed-off-by: Aditya R <arajan@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
I don't think we do, and it would be a good addition. |
Signed-off-by: Aditya R <arajan@redhat.com>
|
Okay added a case for missing |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buildkitanddockeracceptsrequiredflag astruewhen provided without any value in--mount=type=secretso lets do same for buildah.Example usage
Closes: containers/podman#18438
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?