executor: apply label to only final stage via --label
#4817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Dont think conformance failures are related to this PR, looks like temporary outage. |
|
LGTM |
|
Looks like #4818 is also having conformance test issues. Ping @edsantiago |
|
a nitty comment suggestion, otherwise LGTM once the conformance tests are righted. |
In containers#4673 we made a change were we were applying labels to end of each stage, which is different than what we were doing before i.e applying label at the end of the each step. However buildkit does not adds label to any stage or steps it only adds label at the end of final stage so lets do that. Closes: containers#4804 Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
force-pushed
the
label-only-last-stage
branch
from
ab2280d
to
0766b00
Compare
|
Rebased after #4819 |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4673 we made a change were we were applying labels to end of each stage, which is different than what we were doing before i.e applying label at the end of the each step.
However buildkit does not adds label to any stage or steps it only adds label at the end of final stage so lets do that.
Closes: #4804
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?