CI: Support testing w/ podman-next COPR packages #4830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cevich
force-pushed
the
ci_next
branch
3 times, most recently
from
7c9f045
to
f64785e
Compare
cevich
changed the title
|
LGTM |
edsantiago
requested changes
Jun 1, 2023
Sometimes important updates need to be made to dependent packages and run through CI w/o waiting for package release and new CI VM image builds. Support this in buildah CI as in podman CI, by updating packages during setup when the magic string is present and PR is in draft-mode. Note: To support containerized testing, both `CIRRUS_CHANGE_TITLE` and `CIRRUS_PR_DRAFT` env. vars. are passed through. For these tasks, this will result in **TWO** updates - One for the host, and another one in the container. Signed-off-by: Chris Evich <cevich@redhat.com>
Yeah probably. It got way more out of hand in podman-CI, which is why it's documented there. And still I don't think many/any people read it 😞 |
|
Force-push: Addressed all of Ed's concerns, except the missing docs. |
edsantiago
approved these changes
Jun 1, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/hold cancel |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
Sometimes important updates need to be made to dependent packages and
run through CI w/o waiting for package release and new CI VM image
builds. Support this in buildah CI as in podman CI, by updating
packages during setup when the magic string is present and PR is in
draft-mode.
Note: To support containerized testing, both
CIRRUS_CHANGE_TITLEand
CIRRUS_PR_DRAFTenv. vars. are passed through. For these tasks,this will result in TWO updates - One for the host, and another one
in the container.
How to verify it
CI will pass with and without magic keyword in title.
Which issue(s) this PR fixes:
Special notes for your reviewer:
CI Run when
[CI:NEXT]was in the PR title. I believe the handful of SELinux related test failures are a known issue.Does this PR introduce a user-facing change?