Revendor test tooling + Lint fix. #4863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Golangci-lint < v1.51.1 can't work on systems with golang 1.20. Updating to 1.51.2 then has dependent modules that require a minimum of golang 1.17, requiring a re-vendoring of tooling. Signed-off-by: Chris Evich <cevich@redhat.com>
Fixes golangci-lint message: `tar.TypeRegA has been deprecated since Go 1.11 and an alternative has been available since Go 1.1: Use TypeReg instead.` Signed-off-by: Chris Evich <cevich@redhat.com>
openshift-ci
bot
added
the
kind/failing-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jun 12, 2023
|
(@mtrmac thanks for the suggestion) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
This is a fork of #4772 which only does the
golangci-lintand tooling revendor. There's also a small lint fix for atarpackage. The intent is to see if not including an OS update (as in #4772) will result in a smoother CI outcome.How to verify it
CI will pass
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?