pkg/overlay: add limited support for FreeBSD #4888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
kind/feature
Note: in theory, we could support read/write overlays on FreeBSD using a combination of unionfs and nullfs but this would take two mounts and the API only lets us return a single mount from MountWithOptions. Read only mounts can be done with just nullfs and this is enough to support read only image mounts in podman. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <dfr@rabson.org>
|
LGTM |
|
@vrothberg @flouthoc @giuseppe PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfr, flouthoc, giuseppe, rhatdan, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: in theory, we could support read/write overlays on FreeBSD using a combination of unionfs and nullfs but this would take two mounts and the API only lets us return a single mount from MountWithOptions. Read only mounts can be done with just nullfs and this is enough to support read only image mounts in podman.
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
None
Does this PR introduce a user-facing change?