Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/buildahimage: set config correctly for rootless build user #4905

Merged

Conversation

flouthoc
Copy link
Collaborator

@flouthoc flouthoc commented Jul 3, 2023

For image published at quay.io/containers/buildah buildah should correctly use fuseoverlay for rootless build user fuse-overlayfs.

Closes: #4669

[NO NEW TESTS NEEDED]

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

contrib/buildahimage: set config correctly for rootless `build` user

For image published at `quay.io/containers/buildah` buildah should
correctly use `fuseoverlay` for rootless `build` user `fuse-overlayfs`.

Closes: containers#4669

[NO NEW TESTS NEEDED]

Signed-off-by: Aditya R <arajan@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Jul 3, 2023

$ podman run --user build --device /dev/fuse -v /tmp/dan/:/tmp:Z quay.io/buildah/stable buildah build /tmp
time="2023-07-03T10:35:39Z" level=warning msg="Error loading container config when searching for local runtime: mkdir /home/build/rundir/libpod: no such file or directory"
time="2023-07-03T10:35:39Z" level=error msg="failed to setup From and Build flags: failed to get container config: mkdir /home/build/rundir/libpod: no such file or directory"

Does this fix this issue?

@rhatdan
Copy link
Member

rhatdan commented Jul 3, 2023

LGTM

@flouthoc
Copy link
Collaborator Author

flouthoc commented Jul 4, 2023

@containers/buildah-maintainers PTAL

@rhatdan
Copy link
Member

rhatdan commented Jul 5, 2023

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm

@TomSweeneyRedHat
Copy link
Member

/hold
for happy tests

@TomSweeneyRedHat
Copy link
Member

@flouthoc PTAL, tests are not at all happy

@flouthoc
Copy link
Collaborator Author

flouthoc commented Jul 6, 2023

@TomSweeneyRedHat It was caused due to temporary outage of registry.k8s.io:

@flouthoc
Copy link
Collaborator Author

flouthoc commented Jul 6, 2023

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit 9f3506d into containers:main Jul 6, 2023
34 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

containers/buildah image misses settings for build user
5 participants