packit: Build PRs into default packit COPRs #4959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Building all PRs of all container projects into the same COPR does not properly isolate PRs from each other: E.g. a podman PR currently runs against whichever buildah PR was opened/updated last; in other words, sending a broken buildah PR will instantly break tests for all subsequent podman runs. To avoid that, change the copr_build configuration to use the packit default COPRs, which are specific to the particular PR, and disappear after a few weeks. Depending projects like podman should only run against what landed in buildah/main, i.e. the podman-next COPR. Note that this does not preclude testing a podman PR against an buildah PR: This can be explicitly requested [1]. But most PRs don't change the API and thus should default to isolation. [1] https://packit.dev/posts/testing-farm-triggering [NO NEW TESTS NEEDED] Signed-off-by: Martin Pitt <mpitt@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, martinpitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building all PRs of all container projects into the same COPR does not properly isolate PRs from each other: E.g. a podman PR currently runs against whichever buildah PR was opened/updated last; in other words, sending a broken buildah PR will instantly break tests for all subsequent podman runs.
To avoid that, change the copr_build configuration to use the packit default COPRs, which are specific to the particular PR, and disappear after a few weeks. Depending projects like podman should only run against what landed in buildah/main, i.e. the podman-next COPR.
Note that this does not preclude testing a podman PR against an buildah PR: This can be explicitly requested [1]. But most PRs don't change the API and thus should default to isolation.
[1] https://packit.dev/posts/testing-farm-triggering
What type of PR is this?
What this PR does / why we need it:
This is exactly the same as containers/crun#1260 ; please see the discussion there, this change needs to be applied to all container projects, and then all land together. Let's keep all the relevant discussions and tracking in the crun PR please.
How to verify it
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Discussed with @lsm5 in containers/crun#1260
Does this PR introduce a user-facing change?