Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:BUILD] Packit: add fedora-eln targets and build docs with vendored go-md2man #4964

Merged
merged 2 commits into from Aug 10, 2023

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Aug 9, 2023

fedora-all doesn't include eln targets. We need to add them explicitly.

This PR also gets rid of go-md2man as an rpm dependency and directly builds docs from the vendored go-md2man. This enables easy building on rhel8 and eln.

[NO NEW TESTS NEEDED]

What type of PR is this?

/kind other

What this PR does / why we need it:

Packit tests on ELN

How to verify it

Tasks for ELN will be created in the CI task list.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5
Copy link
Member Author

lsm5 commented Aug 9, 2023

this will need go-md2man vendoring or switching to pandoc.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
`fedora-all` doesn't include eln targets. We need to add them
explicitly.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
@lsm5 lsm5 changed the title [CI:BUILD] Packit: add fedora-eln targets [CI:BUILD] Packit: add fedora-eln targets and build docs with vendored go-md2man Aug 9, 2023
@lsm5
Copy link
Member Author

lsm5 commented Aug 9, 2023

@rhatdan
Copy link
Member

rhatdan commented Aug 9, 2023

LGTM

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 10, 2023
@openshift-merge-robot openshift-merge-robot merged commit 3ec3ecc into containers:main Aug 10, 2023
23 checks passed
@lsm5 lsm5 deleted the main-packit branch August 10, 2023 12:19
@lsm5
Copy link
Member Author

lsm5 commented Aug 15, 2023

/cherry-pick release-1.31

@openshift-cherrypick-robot

@lsm5: new pull request could not be created: failed to create pull request against containers/buildah#release-1.31 from head openshift-cherrypick-robot:cherry-pick-4964-to-release-1.31: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between containers:release-1.31 and openshift-cherrypick-robot:cherry-pick-4964-to-release-1.31"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lsm5
Copy link
Member Author

lsm5 commented Aug 15, 2023

/cherry-pick release-1.31

cherrypick was a mistake. I see it's already in the release branch.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants