Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chroot: setSeccomp add support for ArchPARISC(64) and ArchRISCV64 #4976

Merged
merged 1 commit into from Aug 17, 2023

Conversation

michalbiesek
Copy link
Contributor

@michalbiesek michalbiesek commented Aug 14, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

None

[NO NEW TESTS NEEDED]

@openshift-ci openshift-ci bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 14, 2023
@rhatdan
Copy link
Member

rhatdan commented Aug 14, 2023

/approve
LGTM
Thanks @michalbiesek
Could you repush to allow the tests to run.

@rhatdan
Copy link
Member

rhatdan commented Aug 14, 2023

Signed-off-by: Michal Biesek <michalbiesek@gmail.com>
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, giuseppe, michalbiesek, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [flouthoc,giuseppe,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Aug 17, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 17, 2023
@openshift-merge-robot openshift-merge-robot merged commit 61249b1 into containers:main Aug 17, 2023
36 checks passed
@michalbiesek michalbiesek deleted the setSeccomp-arch branch August 17, 2023 13:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm locked - please file new issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants