Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make,cross: restore loong64 #4979

Merged
merged 2 commits into from Aug 18, 2023

Conversation

michalbiesek
Copy link
Contributor

@michalbiesek michalbiesek commented Aug 15, 2023

Ref: 50a4acb, 5d50a73

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 15, 2023
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomSweeneyRedHat
Copy link
Member

/approved

@TomSweeneyRedHat
Copy link
Member

LGTM
a couple of tests were'nt hip, I've re-run them.

@TomSweeneyRedHat
Copy link
Member

Happy Green Test Buttons

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs rebase.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, michalbiesek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Ref: 50a4acb, 5d50a73

Signed-off-by: Michal Biesek <michalbiesek@gmail.com>
@michalbiesek
Copy link
Contributor Author

This needs rebase.

Rebased.

@rhatdan
Copy link
Member

rhatdan commented Aug 17, 2023

/lgtm
/hold

@openshift-ci openshift-ci bot removed the lgtm label Aug 17, 2023
@rhatdan
Copy link
Member

rhatdan commented Aug 17, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 17, 2023
@rhatdan
Copy link
Member

rhatdan commented Aug 18, 2023

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit b5a8b3a into containers:main Aug 18, 2023
36 checks passed
@michalbiesek michalbiesek deleted the feat-loong64 branch August 18, 2023 09:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm locked - please file new issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants