push: --force-compression should be true with --compression-format
#5013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With discussion from here: containers/podman#19640, it was decided that `--force-compression` must be automatically `true` in case when `--compression-format` is set. Signed-off-by: Aditya R <arajan@redhat.com>
|
@containers/buildah-maintainers @vrothberg @giuseppe @mtrmac PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
mtrmac
reviewed
Aug 30, 2023
Comment on lines
+881
to
+882
| if c.Flag("compression-format").Changed { | ||
| if !c.Flag("force-compression").Changed { |
There was a problem hiding this comment.
(This can be if a && !b { }, saving one level of nesting.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With discussion from here:
containers/podman#19640, it was decided that
--force-compressionmust be automaticallytruein case when--compression-formatis set. Following PR does that and makes behavior ofpodmanandbuildahconsistent.What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?