Don't try to look up names when committing images #5025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
kind/bug
nalind
force-pushed
the
tagging-resolve
branch
from
f415ba4
to
d9bbaed
Compare
Don't try to look up an image by name when we're committing an image, because we don't want to accidentally take advantage of any fuzzy matching that libimage might start doing. Instead, just use the normalization call. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
tagging-resolve
branch
from
d9bbaed
to
7545685
Compare
|
LGTM |
1 similar comment
|
LGTM |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Don't try to look up an image by name when we're committing an image, because we don't want to accidentally take advantage of any fuzzy matching that libimage might start doing. Instead, just use the normalization call.
How to verify it
New integration test!
Which issue(s) this PR fixes:
Fixes #5022
Special notes for your reviewer:
Does this PR introduce a user-facing change?