add/copy: make sure we handle relative path names correctly #5050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that `add` and `copy` handle relative paths given as input correctly, both with and without a context directory being specified. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rhatdan
reviewed
Sep 18, 2023
| if err != nil { | ||
| return fmt.Errorf("computing path of %q relative to %q: %w", glob, contextDir, err) | ||
| rel := glob | ||
| if filepath.IsAbs(glob) { |
There was a problem hiding this comment.
Is this correct? We only append contextDir, if the glob is a Absolute path?
There was a problem hiding this comment.
It isn't appended - we're conditionalizing whether or not we want to convert the matched value to a relative path. We don't need to do that when it's already a relative path.
|
LGTM |
1 similar comment
|
LGTM |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Make sure that
addandcopyhandle relative paths given as input correctly, both with and without a context directory being specified.How to verify it
New integration tests!
Which issue(s) this PR fixes:
Fixes #5049.
Special notes for your reviewer:
Does this PR introduce a user-facing change?