Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing selinux_tag.sh as no longer needed after 580356f #5054

Merged
merged 1 commit into from Sep 19, 2023

Conversation

rahilarious
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@nalind
Copy link
Member

nalind commented Sep 18, 2023

Hi! Thanks for spotting this.
CI's currently tripping over a "must add tests" guardrail. Can you git commit --amend and add "[NO NEW TESTS NEEDED]" to the body of the commit message? That'll override that particular check.

@rhatdan
Copy link
Member

rhatdan commented Sep 18, 2023

LGTM

[NO NEW TESTS NEEDED]

Signed-off-by: Rahil Bhimjiani <rahil3108@gmail.com>
@rahilarious
Copy link
Contributor Author

Can you git commit --amend and add "[NO NEW TESTS NEEDED]" to the body of the commit message? That'll override
that particular check.

Done

@rhatdan
Copy link
Member

rhatdan commented Sep 18, 2023

/approve
/lgtm
/hold
Thanks @rahilarious

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rahilarious, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Sep 19, 2023

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit ad9c345 into containers:main Sep 19, 2023
36 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants