Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Protocol can be specified with --port. Ex. --port 514/udp #5066

Merged
merged 1 commit into from Sep 29, 2023

Conversation

ranjithrajaram
Copy link
Contributor

Updating the buildah-config man page to include port/protocol with --port

/kind documentation

Protocol can be mentioned. This allows the port to be exposed via UDP instead of default TCP

[root@atomic-test tmp]# buildah config --port 53/udp $container
[root@atomic-test tmp]# buildah commit --format docker $container port:latest

[root@atomic-test tmp]# podman create -it -P port:latest
56545611f432ad5557e3ef30204e835403a0f51460b108fc2cf32a27fdb06d28
[root@atomic-test tmp]# podman start 56545611f432ad5557e3ef30204e835403a0f51460b108fc2cf32a27fdb06d28
56545611f432ad5557e3ef30204e835403a0f51460b108fc2cf32a27fdb06d28
[root@atomic-test tmp]# podman port -l 53/udp -> 0.0.0.0:57

Updating the buildah-config man page to include port/protocol with --port

Signed-off-by: Ranjith Rajaram <rrajaram@redhat.com>
@openshift-ci openshift-ci bot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 29, 2023
@ranjithrajaram
Copy link
Contributor Author

While clearing the commit mess of the previous pull request 4862, PR got autoclosed. So filing a new one

@rhatdan rhatdan changed the title Protocol can be specified with --port. Ex. --port 514/udp [CI:DOCS] Protocol can be specified with --port. Ex. --port 514/udp Sep 29, 2023
@rhatdan
Copy link
Member

rhatdan commented Sep 29, 2023

Thanks @ranjithrajaram
LGTM
I wonder if we need a similar update to podman build man page.

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @ranjithrajaram !

@TomSweeneyRedHat
Copy link
Member

A test failed that should not have been caused by this change. Rerunning.

@rhatdan
Copy link
Member

rhatdan commented Sep 29, 2023

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ranjithrajaram, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0d717cd into containers:main Sep 29, 2023
36 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved kind/documentation Categorizes issue or PR as related to documentation. lgtm locked - please file new issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants