Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor containers/common main #5085

Merged
merged 1 commit into from Oct 16, 2023
Merged

Conversation

umohnani8
Copy link
Member

@umohnani8 umohnani8 commented Oct 11, 2023

Pick up changes to move the platform code to its own directory.

What type of PR is this?

/kind other

What this PR does / why we need it:

Bumping the containers/common vendor to pick up some code move changes with the platform code

How to verify it

Buildah should build successfully

Which issue(s) this PR fixes:

Needed for the podman farm build PR

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Update containers/common vendor

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@umohnani8
Copy link
Member Author

Once containers/common#1693 is merged, will remove the replace in go.mod

@packit-as-a-service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

internal/util/util.go Outdated Show resolved Hide resolved
@umohnani8 umohnani8 force-pushed the vendor-common branch 2 times, most recently from e911e49 to 3c8f6de Compare October 12, 2023 19:12
@umohnani8 umohnani8 changed the title [WIP] Vendor containers/common Vendor containers/common main Oct 12, 2023
@umohnani8
Copy link
Member Author

Updated to vendor containers/common main. This will be ready to merge once tests are green

@nalind
Copy link
Member

nalind commented Oct 12, 2023

Code that calls libimage.NormalizePlatform() is just going to break unless it's modified?

@nalind
Copy link
Member

nalind commented Oct 12, 2023

Opened containers/common#1696.

@vrothberg
Copy link
Member

Code that calls libimage.NormalizePlatform() is just going to break unless it's modified?

This happens ~frequently. As long as callers are updated immediately, I think it's OK.

@umohnani8
Copy link
Member Author

umohnani8 commented Oct 13, 2023

This is ready to be merged once tests pass, can I get a final lgtm here please @nalind @rhatdan

@rhatdan
Copy link
Member

rhatdan commented Oct 13, 2023

LGTM but tests are not happy

Pick up changes to move the platform code to its own directory.

[NO NEW TESTS NEEDED]

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
@umohnani8
Copy link
Member Author

Tests are green, can we please merge @rhatdan @nalind @flouthoc

@rhatdan
Copy link
Member

rhatdan commented Oct 16, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 16, 2023
@openshift-ci openshift-ci bot merged commit ade0515 into containers:main Oct 16, 2023
36 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants