Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cirrus and version of golang #5139

Merged
merged 1 commit into from Nov 13, 2023

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Nov 5, 2023

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

[NO NEW TESTS NEEDED]

@openshift-ci openshift-ci bot added the approved label Nov 5, 2023
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM restarted flake

Copy link
Contributor

openshift-ci bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member Author

rhatdan commented Nov 13, 2023

@nalind @cevich PTAL

@nalind
Copy link
Member

nalind commented Nov 13, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 13, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 7a06e68 into containers:main Nov 13, 2023
37 checks passed
@cevich
Copy link
Member

cevich commented Nov 13, 2023

X-ref: #5007

The .cirrus.yml update should probably reference latest. Nobody's likely to remember in the future, that needs updating also.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants