[CI:DOCS] Pass secrets from the host down to internal podman containers #5154
Conversation
|
The commit messages don't jive with the description. Did you mean to glom all this together here? |
rhatdan
changed the title
rhatdan
force-pushed
the
subscriptions
branch
from
5f2f1f4
to
705656e
Compare
|
Nope |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR mentions this as |
|
I don't believe there are any tests that test the buildahimages so I treated it as a Docs update, to save the planet. |
This change will allow RHEL subscriptions from the host to flow to internal containers. Fixes: containers/common#1735 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
force-pushed
the
subscriptions
branch
from
705656e
to
7e0d664
Compare
|
@Luap99 PTAL |
| @@ -65,6 +65,9 @@ RUN dnf -y makecache && \ | |||
|
|
|||
| ADD ./containers.conf /etc/containers/ | |||
|
|
|||
| # Setup internal Buildah to pass secrets/subscriptions down from host to internal container | |||
| RUN printf '/run/secrets/etc-pki-entitlement:/run/secrets/etc-pki-entitlement\n/run/secrets/rhsm:/run/secrets/rhsm\n' > /etc/containers/mounts.conf | |||
There was a problem hiding this comment.
Not a blocker, but is there any reason for doing it this way instead of creating a mounts.conf file in this subdirectory and adding it to the ADD on line 66?
There was a problem hiding this comment.
Nope, but not sure that would be much better.
|
LGTM |
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?