Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update c/{storage,image,common} #5163

Merged

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Nov 14, 2023

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

1 similar comment
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@giuseppe giuseppe force-pushed the consolidate-xdg-runtime-code branch 11 times, most recently from 2eea5e7 to b46cb76 Compare November 16, 2023 07:39
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2023
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2023
@giuseppe giuseppe changed the title [WIP] vendor: update c/storage [WIP] vendor: update c/{storage,image,common} Nov 21, 2023
@giuseppe giuseppe changed the title [WIP] vendor: update c/{storage,image,common} vendor: update c/{storage,image,common} Nov 21, 2023
@giuseppe giuseppe marked this pull request as ready for review November 21, 2023 13:30
@rhatdan
Copy link
Member

rhatdan commented Nov 21, 2023

/approve
/lgtm
/hold

Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@giuseppe
Copy link
Member Author

/hold cancel

@openshift-merge-bot openshift-merge-bot bot merged commit d1a1c53 into containers:main Nov 21, 2023
36 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants