New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conformance tests: archive the context directory as 0:0 #5171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm
/approve
/hold
fae3e24
to
7a7d3f3
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7a7d3f3
to
564fc03
Compare
be7eb82
to
4eca335
Compare
LGTM |
When uploading a context directory to dockerd, generate the archive ourselves so that we can force the ownerships in it to 0:0, which BuildKit seems to expect clients to do. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
789bec9
to
473a755
Compare
/lgtm |
Rebased , squashed and merged |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
When uploading a context directory to dockerd, generate the archive ourselves so that we can force the ownerships in it to 0:0, which BuildKit seems to expect clients to do.
How to verify it
Run those conformance tests!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?